fix: return defined false from stat/lstat in scalar context#105
Draft
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: return defined false from stat/lstat in scalar context#105Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
pp_overload_stat's failure path (empty stat array) popped the argument from the Perl stack but did not push a return value, causing a stack imbalance in scalar context. Real Perl's pp_stat pushes &PL_sv_no (defined false) in scalar/void context when stat fails; the mock was instead leaving the stack short, which caused scalar stat() to yield undef rather than defined false. Code using `defined(stat($f))` or `stat($f) // $default` would observe different behavior under the mock vs real Perl. Fix: check GIMME_V in the failure path and push &PL_sv_no for non-list contexts, matching Perl's own pp_stat semantics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix stack imbalance in
pp_overload_statwhen stat mock returns an empty array (file not found) and the caller uses scalar context.Why
Perl's real
pp_statpushes&PL_sv_no(defined false) in scalar/void context on failure. The mock's failure path popped the argument but never pushed a return value, leaving the stack one element short. This causedstat($f)in scalar context to returnundefinstead of defined false.Code using
defined(stat($f))orstat($f) // $defaultwould observe different behavior under the mock vs real Perl.How
Check
GIMME_Vin thesize < 0early-return path and push&PL_sv_nofor non-list contexts, matching Perl's ownpp_statsemantics.Testing
t/stat-scalar-context.ttests scalar context for both missing and present mocked filesdefined()returns true on failure (matching real Perl)🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 83 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (0 Tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline